Skip to content

Bug 1919737: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danwinship merged 1 commit into from
Feb 18, 2021
Merged

Bug 1919737: UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service #574

danwinship merged 1 commit into from
Feb 18, 2021

Conversation

@Miciah
Copy link

@Miciah Miciah commented Feb 16, 2021

  • pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint for the cluster DNS service.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Modify kube-proxy's logic to special-case the cluster's DNS service and prefer to use the node-local DNS pod, if one exists, for traffic to the DNS service.

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1919737

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kube-proxy now prefers the node-local DNS pod, if one exists, for the cluster DNS service.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@Miciah
UPSTREAM: <carry>: Prefer local endpoint for cluster DNS service
eb33960 
This commit fixes bug 1919737.

https://bugzilla.redhat.com/show_bug.cgi?id=1919737

* pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint
for the cluster DNS service.
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 16, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2021

@Miciah: This pull request references Bugzilla bug 1919737, which is invalid:

  • expected Bugzilla bug 1919737 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1919737: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2021

@Miciah: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah Miciah mentioned this pull request Feb 18, 2021
Merged
@Miciah
Copy link
Author

Miciah commented Feb 18, 2021

#574 passed CI with this carry vendored. Next step is to merge this PR, and then update #574 to do a proper vendor bump.

@danwinship danwinship merged commit 8365549 into openshift:sdn-4.7-kubernetes-1.20.0-rc.0 Feb 18, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2021

@Miciah: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1919737 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1919737: UPSTREAM: : Prefer local endpoint for cluster DNS service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Author

Miciah commented Feb 19, 2021

/cherry-pick sdn-4.6-kubernetes-1.18.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 19, 2021

@Miciah: new pull request created: #581

Details

In response to this:

/cherry-pick sdn-4.6-kubernetes-1.18.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery pushed a commit to Elbehery/kubernetes that referenced this pull request Apr 9, 2021
@k8s-ci-robot
Merge pull request kubernetes#100694 from nilo19/bug/cherry-pick-574
0e4545d 
Cherry pick openshift#574 from Cloud Provider Azure: do not tag user created public IPs
danwinship pushed a commit that referenced this pull request May 13, 2021
@k8s-ci-robot
Merge pull request kubernetes#100693 from nilo19/bug/cherry-pick-574-…
0b2c95c 
…1.21

Cherry pick of kubernetes#100694: Cherry pick #574 from Cloud Provider Azure: do not tag user created public IPs
openshift-merge-robot pushed a commit that referenced this pull request Sep 17, 2021
@k8s-ci-robot
Merge pull request kubernetes#100691 from nilo19/bug/cherry-pick-574-…
aed6b74 
…1.20

Cherry pick of kubernetes#100694: Cherry pick #574 from Cloud Provider Azure: do not tag user created public IPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Miciah @openshift-ci-robot @openshift-cherrypick-robot @danwinship